[buddypress-trac] [BuddyPress Trac] #5437: Add labels to BP Group Settings radio buttons

buddypress-trac noreply at wordpress.org
Fri Feb 28 14:15:55 UTC 2014


#5437: Add labels to BP Group Settings radio buttons
-------------------------+------------------
 Reporter:  tw2113       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.0
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------
Changes (by boonebgorges):

 * milestone:  Awaiting Review => 2.0


Comment:

 Awesome, this looks like a good fix.

 Your patch also demonstrates that our use of `<label for="group-status">`
 is incorrect. Labels go with individual controls, not entire sets. We
 should wrap these options in a `<fieldset>` and then apply a `<legend>`
 instead of a top-level label. tw2113, you fancy updating your patch with
 that change?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5437#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list