[buddypress-trac] [BuddyPress Trac] #5423: Add pagination to group invitations loop

[buddypress-trac]

#5423: Add pagination to group invitations loop
-------------------------+------------------------------
 Reporter:  dcavins      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Groups       |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------
Changes (by boonebgorges):

 * component:  Core => Groups


Comment:

 Thanks for the patch, dcavins. I really like the new technique of loading
 the entire invites list via AJAX on every change - IMO, this simplifies
 everything greatly, and provides for a much more consistent UI. The fact
 that we are able to get pagination in this way is a bonus.

 As I think I mentioned in a previous ticket, our has_invites() queries are
 very lame, and your extension inherited some of that lameness :) It's
 really much more appropriate as a BP_Group_Member_Query query.
 5423.02.patch is an update of your patch, which makes the necessary mods
 to BP_Group_Member_Query and the bp_group_has_members() stack. (These mods
 will also help with some of your other group-invite-related tickets.)

 Could I ask you to take a look at the new patch? First, let me know
 whether you think it's a viable way forward in terms of the queries.
 Second, I ran into a couple issue that may or may not be my fault, but I
 was hoping you could look more closely at.

 - Removing an invitation by unchecking the relevant checkbox doesn't seem
 to work (page refreshes but with the invite still in page)
 - Removing an invitation by clicking Remove Invite seems to break
 sometimes. I got a nonce notice a couple times - maybe after the page is
 reloaded? Not totally sure.

 Thanks for your work on this! Looking like a great improvement (and a good
 excuse to enhance `BP_Group_Member_Query`).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5423#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac