[buddypress-trac] [BuddyPress Trac] #5336: Add "manage invitations" pane to group admin screen

[buddypress-trac]

#5336: Add "manage invitations" pane to group admin screen
-----------------------------------------+--------------------
 Reporter:  dcavins                      |       Owner:
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  2.0
Component:  Groups                       |     Version:  1.9.1
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |
-----------------------------------------+--------------------
Changes (by boonebgorges):

 * component:  Administration => Groups


Comment:

 Hi dcavins -

 Thanks very much for the patch. Some comments:

 - Your mods to `get_invites()` will break backward compatibility. We can't
 change the order of existing parameters (user_id and group_id). And we
 can't change the structure of the default return values; it's currently
 returning an array of IDs, so we must continue to do so, at least by
 default. Either you'll have to build in some backward compatibility stuff
 for this method, or write a new method that does what you need it to do
 (and, optionally, migrate existing uses of `get_invites()` in BP over to
 the new method, deprecating the old one).
 - Related, my gut tells me that you should be able to do what you're
 trying to do in `get_invites()` by using `BP_Group_Member_Query`. That
 class has a param `is_confirmed` that might do it; if not, perhaps you
 could modify that class to add the necessary parameters. Conceptually,
 that seems like a better place for an invites query than as a static
 method on the `BP_Groups_Group` class.

 - "I changed the behavior so that all outstanding group invitations are
 show to all members, but only the inviter or group or site admins can
 "remove" an invite." - I guess the worry is that there will be some
 privacy implications, if I know that someone else in my group has invited
 certain individuals. I have some thoughts about different ways to handle
 this, but it's really a separate issue from pagination, and I don't see a
 reason why the one issue should necessarily hold up the other one (tell me
 if I'm wrong about this). Would you mind removing your changes related to
 this and then posting them in a separate enhancement ticket?

 - Likewise with the "Send Invites" issue. I agree that this is lousy UX,
 and to be honest I don't totally understand why the process of creating an
 invitation is so separate from *sending* it. But I think this should be
 discussed separately, for sanity's sake.

 - What's the motivation for creating the new invites-loop.php template?
 Just consistency with other components?

 - The pagination logic itself seems good, so if we can sort out some of
 the stuff above, I think we can definitely get at least that much in for
 2.0.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5336#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac