[buddypress-trac] [BuddyPress Trac] #5389: Mark notifications as read when the item (blog post, private message thread and so on) is visited
buddypress-trac
noreply at wordpress.org
Sun Feb 23 18:05:20 UTC 2014
#5389: Mark notifications as read when the item (blog post, private message thread
and so on) is visited
--------------------------+------------------------------
Reporter: henry.wright | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Core | Version: 1.9.2
Severity: normal | Resolution:
Keywords: |
--------------------------+------------------------------
Comment (by boonebgorges):
> could we be cheeky and conditionally slip the blog post's ID into the
item_id instead of the activity ID?
We could. But this alone wouldn't be enough, because of multisite. So we'd
have to swap out the item_id *and* the secondary_item_id, in the way that
blog activity items are done. Then, by extension, we'd probably want to
parallel the activity item_id schema for *all* notification types.
I guess I'm not fundamentally opposed to doing that, but we'd want to be
consistent throughout. We'd also then need a review of all uses of the
mark-notifications-read-by-item-id etc functions to make sure that we're
clearing the right things, and in cases where changes are required, we'd
have to do research into whether we'll break backward compatibility by
changing the meaning of the columns.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5389#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list