[buddypress-trac] [BuddyPress Trac] #5419: Object cache active notice

buddypress-trac noreply at wordpress.org
Sat Feb 22 23:41:16 UTC 2014


#5419: Object cache active notice
-------------------------+------------------
 Reporter:  r-a-y        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.0
Component:  Messaging    |     Version:  1.0
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------
Changes (by r-a-y):

 * keywords:   => has-patch


Comment:

 Attached patch:

 * Introduces a new hook - `'messages_notice_before_delete'` to do
 something before a notice is deleted
 * Adds object caching to the `get_active()` method
 * Adds an invalidation function to bp-messages-filters.php
 * Adds a unit test

 I guess what I need feedback on is the unit test.  Should I be putting all
 the asserts in my one method?  Or should I split them up into a different
 file?  I kind of lumped them altogether since the asserts are related to
 one another.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5419#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list