[buddypress-trac] [BuddyPress Trac] #5418: theme compatibility still a problem even after #5301 patch

[buddypress-trac]

#5418: theme compatibility still a problem even after #5301 patch
--------------------------+------------------------------
 Reporter:  chochal       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  Awaiting Review
Component:  Theme         |     Version:  1.9.2
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by r-a-y):

 > Is this going to cause weird problems with people using is_page() as
 well?

 > I'm more concerned about false positives, where is_page() returns true
 on BP pages when it *shouldn't*.

 I should have answered the first question as "No, it will not make a
 difference".

 `is_page()` is returning true on all BP pages since #5301 where we
 switched `is_archive` to `is_page` to accommodate themes like Thesis and
 Attitude.

 So 01.patch doesn't make a difference to `is_page()` whether it's applied
 or not.  It does affect the ~~body~~ post classes though.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5418#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac