[buddypress-trac] [BuddyPress Trac] #5418: theme compatibility still a problem even after #5301 patch
buddypress-trac
noreply at wordpress.org
Fri Feb 21 20:52:49 UTC 2014
#5418: theme compatibility still a problem even after #5301 patch
--------------------------+------------------------------
Reporter: chochal | Owner:
Type: defect (bug) | Status: new
Priority: high | Milestone: Awaiting Review
Component: Theme | Version: 1.9.2
Severity: major | Resolution:
Keywords: has-patch |
--------------------------+------------------------------
Comment (by boonebgorges):
> I'm not really a fan of this. Seems like a hack.
Yes, but all of theme compat is a hack, and registering a dummy post is
*definitely* a hack. We're going to have to be inconsistent somewhere, so
I'm just trying to narrow down the location to where it'll do the least
amount of damage.
I'll be curious to hear what henry.wright says about his use of
`is_page()`. I'm not so concern about those trying to use `is_page()` to
detect BP pages. I'm more concerned about false positives, where
`is_page()` returns true on BP pages when it *shouldn't*.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5418#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list