[buddypress-trac] [BuddyPress Trac] #5144: Don't set 'Create a Group' button as part of the title

[buddypress-trac]

#5144: Don't set 'Create a Group' button as part of the title
--------------------------+---------------------------
 Reporter:  rogercoathup  |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  2.0
Component:  Theme         |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+---------------------------
Changes (by rogercoathup):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Hi Boone,

 I think you are a missing a filter in your patches.  For consistency, and
 to allow us to modify the button that's generated!, the arguments should
 be filtered before they are passed to bp_get_button.

 e.g.    For group new topic button, we filter the arguments:
         return bp_get_button( apply_filters(
 'bp_get_group_new_topic_button', $button ) );

 I suggest your patch should be modified accordingly, e.g. line 1890 in
 groups-template should be amended to:

 return bp_get_button( apply_filters( 'bp_get_group_create_button', $button
 ));

 Cheers, Roger

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5144#comment:25>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac