[buddypress-trac] [BuddyPress Trac] #5144: Don't set 'Create a Group' button as part of the title

buddypress-trac noreply at wordpress.org
Thu Feb 20 21:02:33 UTC 2014


#5144: Don't set 'Create a Group' button as part of the title
--------------------------+---------------------------
 Reporter:  rogercoathup  |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  2.0
Component:  Theme         |     Version:  1.7
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7942"]:
 {{{
 #!CommitTicketReference repository="" revision="7942"
 Introduce blog- and group-create button functions, and use to build
 directory headers in bp-legacy

 The new functions bp_get_blog_create_button() and
 bp_get_group_create_button()
 standardize the treatment of these buttons by using bp_get_button(). They
 also
 make life easier for themers, who will not need to build the buttons from
 scratch.

 In this changeset we modify the way that bp-legacy loads these buttons
 into the
 titles of the directory pages. Previously, it was done directly in BP's
 theme
 compat layer, with the result that all template packs had to follow the
 questionable practice of embedding a button inside of a header element.
 Now,
 the directory title is a string, but is filtered; bp-legacy then chooses
 to
 add a button by using the new create-button functions + the new filters.

 Fixes #5144

 Props hnla, r-a-y
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5144#comment:21>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list