[buddypress-trac] [BuddyPress Trac] #5144: Don't set 'Create a Group' button as part of the title

buddypress-trac noreply at wordpress.org
Thu Feb 20 11:54:46 UTC 2014


#5144: Don't set 'Create a Group' button as part of the title
--------------------------+------------------
 Reporter:  rogercoathup  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.0
Component:  Theme         |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by boonebgorges):

 hnla - I do like the idea of having a template-level function for creating
 the Create a Group button. We do this for other buttons, and I'd imagine
 it makes life easier for themers. Off the top of my head, I'd say that the
 function's internals would be better if they used `bp_get_button()`, and
 if the value were returned rather than echoed so that it could be used in
 a filter.

 However, for the actual implementation, I think that the filter approach
 seems a bit arcane. We can just do something like `__( 'Groups',
 buddypress ) . bp_get_group_create_button()` in `directory_dummy_post()`.
 And then themers (eg in the new templates) can just call the function
 directly in the template.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5144#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list