[buddypress-trac] [BuddyPress Trac] #5144: Don't set 'Create a Group' button as part of the title

buddypress-trac noreply at wordpress.org
Wed Feb 19 21:34:54 UTC 2014


#5144: Don't set 'Create a Group' button as part of the title
--------------------------+------------------
 Reporter:  rogercoathup  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.0
Component:  Theme         |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by hnla):

 On the other hand do we want to pull that markup completely? Probably the
 ultimate desire, remove markup from a core file? In which case if we do
 that and leave a filter in place then we simply take a view that
 functions.php handles the markup for these buttons moving forward; in bp-
 legacy we add the button markup but in this instance we filter it back to
 $title preserving that established behaviour for new templates we pass
 markup to a do_action as I've set things up in template pack - the edge
 case stands, doubt whether many have overloaded functions.php but if they
 have it's a simple fix and we do have historical precedence for making
 little changes like this; iirc user account action buttons.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5144#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list