[buddypress-trac] [BuddyPress Trac] #4636: Reinstate activity item for user profile changes

buddypress-trac noreply at wordpress.org
Mon Feb 10 14:16:13 UTC 2014


#4636: Reinstate activity item for user profile changes
---------------------------+------------------
 Reporter:  DJPaul         |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  2.0
Component:  XProfile       |     Version:  1.1
 Severity:  normal         |  Resolution:
 Keywords:  needs-refresh  |
---------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch => needs-refresh


Comment:

 Thanks for the feedback, henry.wright. With 4636.02, there's no mechanism
 in place to test which fields have been successfully updated. It doesn't
 check to see which (or even whether) fields have changed since before the
 update. I guess I was thinking that there weren't many instances where
 someone would go and save their profile without updating anything, so I
 figured it wasn't worth the check. But I guess I'd forgotten about private
 fields. It does seem likely that someone would go and update only a
 private field, and this would make the activity update confusing at best.

 So, I guess back to the drawing board. But the question remains of how to
 treat private fields. I guess the logic is something like this:
 - If a user has updated at least one public field, post an activity update
 - If user has updated no fields, or if all the fields updated are less
 than completely public, don't post an update

 The way our hide_sitewide flag works, I think it'll be impossible to do
 anything more fine-grained.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4636#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list