[buddypress-trac] [BuddyPress Trac] #5272: Use $args parameter on BP_Blogs instead of 8 variables
buddypress-trac
noreply at wordpress.org
Fri Feb 7 19:13:14 UTC 2014
#5272: Use $args parameter on BP_Blogs instead of 8 variables
------------------------------------------------------+------------------
Reporter: lenasterg | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.0
Component: Blogs | Version:
Severity: normal | Resolution:
Keywords: needs-testing has-patch needs-unit-tests |
------------------------------------------------------+------------------
Changes (by boonebgorges):
* keywords: needs-refresh => needs-testing has-patch needs-unit-tests
Comment:
Thanks, lenasterg. In the future, if you could run the 'patch' command
from wp-content/plugins/buddypress, that'd create a single patch for all
files. And also, if you could *please* turn off whatever in your IDE is
using spaces instead of tabs and is stripping whitespace from function
arguments, that'd be helpful.
The $args part of this patch looks good at a glance, but it's going to
need some unit tests before I feel comfortable making the change.
5272.patch contains a reformatted version of just those changes. I don't
have time to continue working on it at the moment.
The patch also contained some `show_hidden` enhancements throughout the
component, as well as some `limit`/`per_page` juggling. Neither of these
is a bad idea, but they should both be introduced as their own tickets
with separate patches. Thanks!
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5272#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list