[buddypress-trac] [BuddyPress Trac] #4571: Changes in Gravatar APIs result in failed fallback on default avatars

[buddypress-trac]

#4571: Changes in Gravatar APIs result in failed fallback on default avatars
---------------------------+-----------------------
 Reporter:  boonebgorges   |       Owner:
     Type:  defect (bug)   |      Status:  reopened
 Priority:  normal         |   Milestone:  2.0
Component:  Core           |     Version:
 Severity:  major          |  Resolution:
 Keywords:  needs-refresh  |
---------------------------+-----------------------

Comment (by boonebgorges):

 I studied 4571.01.patch and it looks good, with the exception of one case.
 When calling `bp_core_fetch_avatar()` with `no_grav` set to true, the
 patch has you fall back on `bp_core_avatar_default()`. But we shouldn't be
 sending people to Gravatar if they've specifically asked not to be - this
 could potentially be a case where we break existing sites that need to
 force Gravatar off for one reason or other. So I've added a $type param to
 the _default_ functions that lets you force local (with default to
 gravatar). Not super elegant, but we've gotta work with what we've got
 here :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4571#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac