[buddypress-trac] [BuddyPress Trac] #5967: Paginate links are stuck on a page number if javascript is disabled

[buddypress-trac]

#5967: Paginate links are stuck on a page number if javascript is disabled
------------------------------+------------------
 Reporter:  imath             |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  2.2
Component:  All Components    |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch 2nd-opinion => has-patch commit


Comment:

 > If for instance we were using 'paged' instead of 'upage', 'bpage'...
 there wouldn't be any trouble.

 Yeah. Now that I look at it more closely, `paginate_links()` (and
 `get_pagenum_link()`, which I think is part of the problem in our specific
 case) have hardcoded references to 'paged'. But this is only for the
 purpose of setting up the `$defaults` array. So I suppose it's the
 responsibility of people using the function (like BP) to override these
 defaults as necessary, which is what your suggested patch is doing. (As a
 side note, I think that it'd be possible to rework `paginate_links()` and
 related functions so that the defaults were more responsive to custom
 query vars, but this is a bigger job than I feel like tackling today :) )

 Carry on, good sir.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5967#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac