[buddypress-trac] [BuddyPress Trac] #5934: Enabling suggestions for @-mentions in groups component
buddypress-trac
noreply at wordpress.org
Sat Dec 20 22:56:25 UTC 2014
#5934: Enabling suggestions for @-mentions in groups component
--------------------------------------+------------------
Reporter: m@… | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.2
Component: Groups | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch |
--------------------------------------+------------------
Comment (by DJPaul):
I have done some poking, as you can see from the commits. I have added a
new patch, 5934.03.patch.
I didn't like the idea of pre-filtering the AJAX response to get the Group
ID (I'm not sure that would have worked, anyway), plus we needed some
refactoring to let each component filter whether the mentions scripts
should load or not, to better match what we try to do elsewhere in BP. I
came up with an approach of storing the Group ID in the textarea as a data
attribute.
I do not believe we should add support to the legacy Group Forums unless
someone has an extremely convincing argument otherwise.
I also think that pre-caching the user's friends, even in a group,
generally makes sense most of the time. Since mentions in groups will be
new for 2.2, how about we leave this pre-cache as it currently is, and
revisit for a future release (and see if we get any user feedback)?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5934#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list