[buddypress-trac] [BuddyPress Trac] #5838: Remove "Profile" from Member page title

[buddypress-trac]

#5838: Remove "Profile" from Member page title
--------------------------+-----------------------
 Reporter:  sooskriszta   |       Owner:  djpaul
     Type:  enhancement   |      Status:  reopened
 Priority:  normal        |   Milestone:  2.2
Component:  Text Changes  |     Version:  2.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by r-a-y):

 Thanks for the feedback!

 > $span = strpos( $bp->bp_nav[$component_id]['name'], '<span' ); What
 items have a span? Is this to cover components with item counts in their
 names?

 Yup!  You got it.  The default BP components that add counts to the nav
 name are - Friends, Groups, Notifications, Messages.  This isn't counting
 plugins.  If the language file is using a different element, then the
 <span> search doesn't work.  Could use regex or `strip_tags` and remove
 all numbers?

 > I think the // translators comment needs to be directly above the line
 of code it refers to.

 Thanks for that tidbit.  This should be fixed in the updated patch.

 > The construction in Append action name if we're on a member component
 sub-page looks a bit dubious from a translation POV (e.g. in case you need
 to re-order the position of the seperator)

 Right.  The updated patch uses the `sprintf()` argument syntax used to
 construct the current page title, which I kinda hate, but I guess there's
 no other way.

 Let me know what you think.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5838#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac