[buddypress-trac] [BuddyPress Trac] #5944: BP Members Hooks Documentation

[buddypress-trac]

#5944: BP Members Hooks Documentation
--------------------+-----------------------------
 Reporter:  tw2113  |       Owner:
     Type:  task    |      Status:  new
 Priority:  normal  |   Milestone:  Future Release
Component:  Core    |     Version:
 Severity:  normal  |  Resolution:
 Keywords:          |
--------------------+-----------------------------

Comment (by boonebgorges):

 Replying to [comment:7 tw2113]:
 > Conflicted regarding the bp_core_signup_blog filter.
 >
 > {{{return apply_filters( 'bp_core_signup_blog', wpmu_signup_blog(
 $blog_domain, $blog_path, $blog_title, $user_name, $user_email, $usermeta
 ) );}}}
 >
 > The conflict comes from the fact that wpmu_signup_blog doesn't actually
 return anything, so we're filtering nothing and also returning nothing.
 >
 > Luckily, we only use the function in one location, and the variable the
 return value is assigned to is not used again.

 Good catch, and groan. I'd say "rip it out" but it's possible that someone
 is actually using that filter to provide a return value in some cases. I'd
 suggest doing your normal documentation, and noting in the long
 description that the filter returns no value by default, and is left in
 place for backward compatibility.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5944#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac