[buddypress-trac] [BuddyPress Trac] #6063: Support meta query in bp_has_message_threads()

buddypress-trac noreply at wordpress.org
Thu Dec 11 01:06:48 UTC 2014


#6063: Support meta query in bp_has_message_threads()
-------------------------+------------------
 Reporter:  r-a-y        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  2.2
Component:  Messaging    |     Version:
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------

Comment (by boonebgorges):

 The meta_query changes look solid to me!

 I feel somewhat uneasy about all the refactoring of these methods, given
 the sad state of test coverage. (Are you surprised by this uneasiness? ;)
 ) Maybe we could at least get a test for each of the methods where you're
 switching to the array notation for params (with the `@expectedDeprecated`
 flag to ignore the `_doing_it_wrong()`) just to demonstrate that the old-
 form params are translated properly?

 Otherwise yeah, let's do this for 2.2.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6063#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list