[buddypress-trac] [BuddyPress Trac] #6059: BP_Activity_Activity:get() doesn't respect 'max' parameter

buddypress-trac noreply at wordpress.org
Tue Dec 9 00:44:36 UTC 2014


#6059: BP_Activity_Activity:get() doesn't respect 'max' parameter
--------------------------+------------------------------
 Reporter:  dcavins       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Activity      |     Version:
 Severity:  minor         |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by boonebgorges):

 Thanks for doing this research, dcavins, though I wish I could say it shed
 much light on the situation :)

 I don't have a strong feeling about how to handle all this. My first
 inclination would be to leave it pretty much as-is, and encourage people
 to use `per_page` in the official documentation. If we can think of a
 relatively consistent way to define the concept of 'max' such that it
 doesn't completely duplicate 'per_page', that's fine - but we should be
 extremely careful about breaking backward compatibility, unless there's a
 good reason to do so.

 So, what do you think we should do about this mess?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6059#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list