[buddypress-trac] [BuddyPress Trac] #6055: Cancelling a friendship never deletes the corresponding activities

[buddypress-trac]

#6055: Cancelling a friendship never deletes the corresponding activities
-----------------------------------+------------------
 Reporter:  imath                  |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  2.2
Component:  Friends                |     Version:  1.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------
Description changed by imath:

Old description:

> Relative to #6040
>
> Since version 1.1, the action 'friendship_accepted' is not used anymore.
> Each time a friendship is confirmed 2 activities are created for each
> user of the relationship (1 of the activity is hide_sitewide) and the
> action is 'friendship_created' for both activities.
>
> The problem is in {{{friends_remove_friend()}}} when this function is
> using {{{friends_delete_activity()}}}, the action argument is using the
> action that has disappeared since 1.1. As a result, activities about the
> friendship are never deleted.
>
> I suggest the attach patch to make sure friends_remove_friend() will
> actually remove the activities.

New description:

 Relative to #6040

 Since version 1.1, the action 'friendship_accepted' is not used anymore.
 Each time a friendship is confirmed 2 activities are created for each user
 of the relationship (1 of the activity is hide_sitewide) and the action is
 'friendship_created' for both activities.

 The problem is in {{{friends_remove_friend()}}} when this function is
 using {{{friends_delete_activity()}}}, the action argument is using the
 action that has disappeared since 1.1. As a result, activities about the
 friendship are never deleted.

 I suggest the attached patch to make sure friends_remove_friend() will
 actually remove the activities.

--

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6055#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac