[buddypress-trac] [BuddyPress Trac] #4988: bp_has_activities to accept multi scope
buddypress-trac
noreply at wordpress.org
Thu Dec 4 07:33:02 UTC 2014
#4988: bp_has_activities to accept multi scope
-------------------------+------------------
Reporter: henrywright | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.2
Component: Activity | Version: 1.2
Severity: normal | Resolution:
Keywords: |
-------------------------+------------------
Comment (by r-a-y):
`02.patch` switches the syntax to use the same recursive, nested query
syntax as introduced by boonebgorges to WP and to `BP_XProfile_Query`.
(See comment:7.)
I've also opted to use the approach by boonebgorges to separate the
recursive query syntax into its own class - `BP_Recursive_Query` - though
this is not in WP core. (See
https://core.trac.wordpress.org/ticket/29642#comment:6 for more details.)
`BP_Activity_Query` extends this class; at the moment, `BP_XProfile_Query`
doesn't extend this class, though my hope is that it eventually will.
Supports the same compare operators as `BP_XProfile_Query` except
`'EXISTS'` and `'NOT EXISTS'` because those operators rely on JOINs and I
don't really think we need them. If we do need `'EXISTS'` / `'NOT
EXISTS'`, I'll do up another patch.
Still need a bit of feedback from comment:4 regarding the `'override'`
approach that I've chosen to adopt. I might need to write a few more unit
tests that shows off the problem. But, I think we're in a better spot
then before.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4988#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list