[buddypress-trac] [BuddyPress Trac] #5821: Update grunt build tools - Fixes JS & CSS build process
buddypress-trac
noreply at wordpress.org
Tue Aug 19 16:18:49 UTC 2014
#5821: Update grunt build tools - Fixes JS & CSS build process
--------------------------+------------------
Reporter: netweb | Owner:
Type: defect (bug) | Status: new
Priority: highest | Milestone: 2.1
Component: Core | Version:
Severity: blocker | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by DJPaul):
I've only time to eyeball the changes right now, but I think it looks OK.
Thanks for the patch, netweb.
The line ending and other whitespace changes are always going to be
committed separately from anything else, so a separate patch for those
would have been helpful, but at least with Git, we can be selective with
files during commits, so this isn't a big deal.
> sort the tasks alphabetically
Thanks for not mixing this up into this patch. :) The original idea was to
have the tasks listed in the order that they're executed in (as much as
possible, anyway) so that it's easier to read the file and better
understand what's going on (without having to refer to the registerTask
lines constantly).
Listing things alphabetically, especially considering that some of our
commands run in SOURCE_DIR and some in BUILD_DIR, I think will make things
more confusing. Therefore I don't think we'll want to do this with
BuddyPress, unless the other core devs feel very extremely strongly about
having this in alphabetical order.
> Removes unused grunt-phpunit
Are you sure this isn't used by the `phpunit` task inside the `test` task?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5821#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list