[buddypress-trac] [BuddyPress Trac] #5694: Issue with the ampersand character in members search

[buddypress-trac]

#5694: Issue with the ampersand character in members search
------------------------------+---------------------
 Reporter:  dontdream         |       Owner:  imath
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  2.1
Component:  Members           |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by imath):

 * owner:   => imath
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8928"]:
 {{{
 #!CommitTicketReference repository="" revision="8928"
 Make sure BP_User_Query returns correct results when search term contains
 the Ampersand character

 1. Search terms containing this character was problematic as the "&" is a
 query var delimiter used in {{{bp_legacy_theme_ajax_querystring()}}} to
 build the ajax querystring

 2. When a xProfile field is saved, the value is sanitized using the
 {{{xprofile_filter_kses()}}} filter which is converting "&" to "&"
 before inserting the value in database.

 Urlencoding the search terms in {{{bp_legacy_theme_ajax_querystring()}}}
 and applying {{{wp_kses_normalize_entities()}}} to search terms in
 {{{BP_User_Query}}} & in {{{bp_xprofile_bp_user_query_search()}}} make
 sure the correct results are returned to the user.

 Fixes #5694
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5694#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac