[buddypress-trac] [BuddyPress Trac] #5477: Allow bp_has_groups to return all groups

buddypress-trac noreply at wordpress.org
Wed Aug 13 17:26:48 UTC 2014

#5477: Allow bp_has_groups to return all groups
 Reporter:  dcavins      |       Owner:  dcavins
     Type:  enhancement  |      Status:  assigned
 Priority:  normal       |   Milestone:  2.1
Component:  Groups       |     Version:
 Severity:  minor        |  Resolution:
 Keywords:  has-patch    |
Changes (by boonebgorges):

 * keywords:  has-patch needs-unit-tests dev-feedback => has-patch
 * milestone:  2.2 => 2.1


 > BP_Groups_Group::get() doesn't try to set a default. I'll update the
 tests and submit a new patch.

 Oy, you're right. Sorry about that.

 >  So it's OK to lump some tests together, if they basically test the same
 parameters? (I'm thinking more of code style than functionality.)

 Ideally, test case methods would be as small as possible. It makes
 debugging easier, because one failed assertion in a test marks the whole
 test as failed. However, in cases where lumping them together creates
 major performance improvements, I think it's fine to do so. Thanks again.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5477#comment:9>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list