[buddypress-trac] [BuddyPress Trac] #5477: Allow bp_has_groups to return all groups

buddypress-trac noreply at wordpress.org
Tue Aug 12 22:01:16 UTC 2014


#5477: Allow bp_has_groups to return all groups
-------------------------------------------------+-------------------------
 Reporter:  dcavins                              |       Owner:  dcavins
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  2.2
Component:  Groups                               |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  has-patch needs-unit-tests dev-      |
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by dcavins):

 I've added a few test cases to cover setting `page` & `per_page`
 parameters to specific values, setting `page` & `per_page` parameters to
 `false` and setting `per_page` to -1 in `BP_Groups_Group::get()`.

 Please offer feedback about the unit tests, especially; I'd like to know
 that I'm testing the right situations. (For instance, these tests test
 `BP_Groups_Group::get()` behavior. Should I instead be testing
 `groups_get_groups()` or the `bp_has_groups()` loop?)

 This is for 2.2, so there's no urgency on feedback. Thanks!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5477#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list