[buddypress-trac] [BuddyPress Trac] #5674: Need actions on Add/Edit admin screens for xProfile component
buddypress-trac
noreply at wordpress.org
Mon Aug 11 13:27:03 UTC 2014
#5674: Need actions on Add/Edit admin screens for xProfile component
-------------------------+------------------
Reporter: slaFFik | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.1
Component: XProfile | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------
Changes (by boonebgorges):
* milestone: Future Release => 2.1
Comment:
I think it's the fact that you're using `diff` rather than `svn diff`.
It's not translating the line endings and filepaths from Windows to Linux.
I know it can be a bit of a pain, but if you can get svn up and running
for generating patches, it would make our lives much easier (especially
for patches that make more modifications of existing code than this one
does!)
I'm taking care of the patch manually right now. Looks mostly very good.
One quibble is that I don't think that the postbox-container-2 div makes
sense for us at the moment; WP includes this because they natively support
the output of metaboxes in this section using the API (add_meta_box( ...
'advanced' ... )) but we don't. It'd only make sense if we did do_action(
'edit_form_advanced' ) and then ensured that we only caught the metaboxes
registered for this page, but this is more of a change than I want to
endeavor this close to our beta release.
I'm also going to move 'xprofile_group_after_submitbox' outside of the
'submitdiv' element, so it better parallels
'xprofile_group_before_submitbox'.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5674#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list