[buddypress-trac] [BuddyPress Trac] #5509: invites-loop template re-factoring

buddypress-trac noreply at wordpress.org
Thu Aug 7 13:32:17 UTC 2014

#5509: invites-loop template re-factoring
 Reporter:  hnla                             |       Owner:
     Type:  enhancement                      |      Status:  new
 Priority:  low                              |   Milestone:  2.2
Component:  Theme                            |     Version:
 Severity:  minor                            |  Resolution:
 Keywords:  needs-refresh needs-patch early  |

Comment (by hnla):

 Second patch addresses invites-loop.php.

 This adds a check for invite friends list returning false - a member can
 have friends  yet those friends  for one reason or another ( already
 members of group) would result in rendering the ul markup without any data
 so check checks and if false adds a message to the effect that ''Your
 friends are currently all members of this group'' t's probably an edg case
 that this would occur but did with my test setup so would seem sensible to
 allow for the possibility?

 The other changes are simply to add headings for the screen and for the
 actual 'Current invites section of the screen.

 One concern is, as Boone stated originally, that other group screens
 aren't provided with headings causing a little inconsistency, although
 that really is more a fault of the other screens as these headings make
 sense and would definitely be added under any other circumstance.

 >The markup for the headings (h1 and h2) is causing flow problems with the
 floated elements on the screen.

 There is an issue here but it's one caused by twentytwelve which has a
 very odd global ruleset on generic heading elements of 'clear: both' this
 is an odd rule as it's clearly highly theme specific and not the sort of
 rule one would ever write, only clearing where specifically required, I
 have spotted this as an issue before and therefore decided that it ought
 to be addressed for BP elements so under the BP namespace token
 '#buddypress' I added a ruleset of 'clear: none' for grouped heading
 elements as I can think of no reason one would need to be clearing these
 within bp screen sections.

 Headings as suggested were dropped down to h2/h3 however font sizing not
 addressed as I've noticed a fair few issues lately with our attempts to
 dictate font sizes running into pretty bad compound errors, my thinking is
 that BP's only real option is use keywords or rem units here to avoid
 those problems, but equally not sure BP should be trying to style a major
 element on behalf of a theme.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5509#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list