[buddypress-trac] [BuddyPress Trac] #5601: Activity item: post link

[buddypress-trac]

#5601: Activity item: post link
-------------------------+-----------------------------
 Reporter:  slaFFik      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  low          |   Milestone:  Future Release
Component:  Activity     |     Version:
 Severity:  minor        |  Resolution:
 Keywords:  needs-patch  |
-------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:   => needs-patch
 * priority:  normal => low
 * type:  defect (bug) => enhancement
 * severity:  normal => minor
 * milestone:  Awaiting Review => Future Release


Comment:

 This is intended behavior. See r7447 #4367

 We now dynamically generate activity action strings, so some of the force
 of the original ticket is lost. However, we *do* still cache the post URL
 in activitymeta, at least in the case of 'new_blog_comment'; see
 https://buddypress.trac.wordpress.org/browser/trunk/bp-blogs/bp-blogs-
 activity.php#L94. So we still have essentially the same problem: when a
 post link is changed (either by changing the specific permalink or by
 changing permalink settings and invalidating *all* cached URLs) the cached
 value has to be flushed. And in the case of 'new_blog_post', we would have
 to institute a similar activitymeta caching strategy, since we'd no longer
 be able to concatenate the URL reliably using the post id.

 To "fix" the issue here, we would need to do proper invalidation of
 'post_url' and 'post_title' activitymeta. This is a lot of work. There are
 many places where we'll have to check for invalidation. And in the case
 where *all* post_url values are made incorrect, we would have to have a
 fairly easy way of wiping them all out. (Like, say, deleting them all and
 then letting them regenerate individually when
 `bp_blogs_format_activity_action_new_blog_comment()` is run.)

 I'm not fundamentally opposed to making these changes, but they are a lot
 of work to fix something that arguably is not really broken. I'll put this
 ticket into Future Release, and if anyone would like to take it up as a
 project, please feel free.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5601#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac