[buddypress-trac] [BuddyPress Trac] #5563: wp_signups table upgrade problem

[buddypress-trac]

#5563: wp_signups table upgrade problem
-----------------------------------+--------------------
 Reporter:  Denis-de-Bernardy      |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  highest                |   Milestone:  2.0.1
Component:  Update/Install         |     Version:  2.0
 Severity:  major                  |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+--------------------

Comment (by johnjamesjacoby):

 Replying to [comment:16 r-a-y]:
 > `$wpdb->signups` is not defined in those `exists()` functions so the
 check will return false.  What happens then is the upgrade or install
 scripts will attempt to do their thang causing the DB errors.

 These two empty checks are inverse. If `$wpdb->signups` is already defined
 in `bp_core_signups_table_exists()` then we know for sure the table exists
 so return true (without the additional database query). If it's not
 defined in `bp_core_signups_id_column_exists()` then we know the column
 does not exist so return false (without the additional database query).

 Seems like that's the intended sequence? Why would we want to remove those
 checks, and accidentally check for a column in a table that might not
 exist?

 Would it be easier to suppress the errors inside
 `bp_core_upgrade_signups()` also? Does the existing code even work for you
 at all in terms of updating the signups table from the old version to the
 new?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5563#comment:17>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac