[buddypress-trac] [BuddyPress Trac] #5553: BP 2.0 upgrade routine improperly deletes existing user roles if activation_key usermeta is present

[buddypress-trac]

#5553: BP 2.0 upgrade routine improperly deletes existing user roles if
activation_key usermeta is present
-----------------------------------+--------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  highest                |   Milestone:  2.0.1
Component:  Core                   |     Version:  2.0
 Severity:  critical               |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+--------------------

Comment (by boonebgorges):

 imath - 5553.05.diff looks fine to me.

 What do you think of changing the `'fields'` clause in the `get_users()`
 function to `'all'`? (Or even an array of the fields we need - I think its
 user_login, user_pass, user_registered, user_email.) `all_with_meta` loads
 a very large amount of additional data into memory (and requires a
 potentially huge SQL query); from what I can see, this data is never used.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5553#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac