[buddypress-trac] [BuddyPress Trac] #5563: wp_signups table upgrade problem

[buddypress-trac]

#5563: wp_signups table upgrade problem
-------------------------------+------------------------------
 Reporter:  Denis-de-Bernardy  |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Update/Install     |     Version:  2.0
 Severity:  normal             |  Resolution:
 Keywords:  has-patch          |
-------------------------------+------------------------------
Changes (by r-a-y):

 * keywords:   => has-patch


Comment:

 Thanks for getting to this before I was able to, JJJ.

 Using r8302 still caused the DB error that Denis-de-Bernardy posted.

 02.patch gets rid of these errors.

 * I made some changes to `bp_core_maybe_upgrade_signups()` to check to see
 if the `signup_id` column exists in the `wp_signups` table.  If it doesn't
 exist, then we proceed with upgrading the signups table.

 * We also need to upgrade the signups table ''before'' installing the
 signups table for cases where Gravity Forms already created the table.

 I was able to test on a fresh install of WP, then activating Gravity Forms
 / Gravity Forms User Registration, then activating BP trunk and the DB
 errors are gone.

 One last test I want to do is on a BP 2.0 install that still has this bug
 and then upgrading to trunk to see the errors are gone.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5563#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac