[buddypress-trac] [BuddyPress Trac] #5553: BP 2.0 upgrade routine improperly deletes existing user roles if activation_key usermeta is present

[buddypress-trac]

#5553: BP 2.0 upgrade routine improperly deletes existing user roles if
activation_key usermeta is present
-----------------------------------+--------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  highest                |   Milestone:  2.0.1
Component:  Core                   |     Version:  2.0
 Severity:  critical               |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+--------------------

Comment (by imath):

 Replying to [comment:10 boonebgorges]:

 > On that note, 5553.02.patch looks like the prudent route to me.

 I'm sorry to insist, i agree with all Paul and you said, i just have a
 problem with the case where a user has a user_status set to 2 and a user
 meta activation_key but with an empty value.

 5553.02.patch will not put this user in the signups table as the
 activation_key is empty. So After upgrade, this user will be able to log
 in even if his status is set to 2.

 But that might be another problem see bp_core_signup_disable_inactive() at
 line 1755

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5553#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac