[buddypress-trac] [BuddyPress Trac] #5160: Use gruntjs to generate minified versions of the js and css files everywhere.
buddypress-trac
noreply at wordpress.org
Thu Apr 17 17:30:37 UTC 2014
#5160: Use gruntjs to generate minified versions of the js and css files
everywhere.
-------------------------+------------------
Reporter: enej | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.1
Component: Core | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+------------------
Comment (by boonebgorges):
> This can be coded around. We don't need to place the burden of
SCRIPT_DEBUG on the developers running from src.
I'd be curious to hear your thoughts on how this should be coded around. I
see that WP is doing this:
https://core.trac.wordpress.org/browser/tags/3.9/src/wp-includes/script-
loader.php#L53 But we don't have the same luxury, because we use the same
constant `SCRIPT_DEBUG`, and it's already been defined by the time WP is
loaded. In any case, we want to support cases where BP /src/ is run out of
either /build or /src WP, so we wouldn't want BP to hijack the constant
even if it could.
So, we could wrap `SCRIPT_DEBUG` in a function like `bp_script_debug()`,
and in that function do a similar /src check to see if we should accept
the value of `SCRIPT_DEBUG` or whatever. Then we'd have to swap out every
current call to `SCRIPT_DEBUG` to use the new function.
I'm fine with doing that, but I will note that there are very few people
running trunk in production anyway, and I would assume that they know what
they're doing. We're a different beast from WP in this way.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5160#comment:11>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list