[buddypress-trac] [BuddyPress Trac] #5549: Xprofile Visibility settings not visible on bp-default theme

[buddypress-trac]

#5549: Xprofile Visibility settings not visible on bp-default theme
--------------------------+------------------------------
 Reporter:  sbrajesh      |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Settings      |     Version:  2.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------
Changes (by r-a-y):

 * component:  Core => Settings


Comment:

 We ran into a similar problem with the Notifications component in v1.9.

 I'm torn because the proper "fix" would be to add full support for the
 "Settings > Profile" tab to bp-default.  It wouldn't be too hard to do
 this, but are we adding new features to bp-default any more?

 Since we do add a "Settings > Profile" item in the WP adminbar, it
 probably does make sense to support bp-default even if this is a new
 feature.

 However, we do need to draw a line in the sand somewhere because we are
 planning on moving bp-default to the WP Themes directory and any new theme
 features after v2.0 will definitely not be added to bp-default.

 I see two approaches:
 1. Add "Settings > Profile" page support to bp-default
 2. In the WP adminbar, only show the "Settings > Profile" subnav item for
 non-bp-default themes (using bp_use_theme_compat_with_current_theme()).
 This page is not a deal-breaker for bp-default as you can still set the
 profile visibility from "Profile > Edit".

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5549#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac