[buddypress-trac] [BuddyPress Trac] #5553: BP 2.0 upgrade routine improperly deletes existing user roles if activation_key usermeta is present

[buddypress-trac]

#5553: BP 2.0 upgrade routine improperly deletes existing user roles if
activation_key usermeta is present
-----------------------------------+--------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  highest                |   Milestone:  2.0.1
Component:  Core                   |     Version:  2.0
 Severity:  critical               |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+--------------------

Comment (by imath):

 r-a-y 's comment made me think a bit more to it

 > What we could also do is remove the 'activation_key' meta entry as well
 before bailing.

 I think he's right, maybe we should :
 1- check for user_status and if !== 2, delete activation key and bail
 2- if activation_key has disappeared and user status is === 2 then
 regenerate the activation key

 So i've changed my mind about 5553.02.patch and suggest 5553.03.diff

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5553#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac