[buddypress-trac] [BuddyPress Trac] #5505: New activity check

[buddypress-trac]

#5505: New activity check
------------------------------+-----------------------
 Reporter:  SGr33n            |       Owner:  imath
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  2.0
Component:  Activity          |     Version:  2.0
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------

Comment (by imath):

 Replying to [comment:22 boonebgorges]:
 > These changes look good to me, imath. If they're fixing the problem for
 everyone, and you feel good about them, go ahead and commit. Thanks.
 Thanks boonebgorges :) Actually something was making feel uncomfortable.
 I've tested it and retested it, found something i was doing wrong so
 corrected it and then i imagine the case where a plugin updated the
 recorded_date. The fix will load this activity as a new one, but we could
 have the 2 same activity on the stream.
 In the example of SGr33n:
 let's say i edit the topic a first time (although i still don't understand
 how this is happening as bbPress is not updating the recorded date..), go
 to the activity stream, load newest and it's on top.
 Now i go back on the topic and edit it again, it will load another time
 and so on and so on....

 So to avoid this, i've added a new check that parses the newest_activities
 to eventually remove potential duplicates. Before committing, i'd like
 your opinions this new version (other opinions are welcome too :) ).

 The trick will be in buddypress.js at line 418 once the 5505.03.patch
 applied. Thanks in advance ;)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5505#comment:23>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac