[buddypress-trac] [BuddyPress Trac] #5519: confusions about BP_Activity_Activity::get_recorded_components() returning recorded components

buddypress-trac noreply at wordpress.org
Mon Apr 7 17:33:27 UTC 2014


#5519: confusions about BP_Activity_Activity::get_recorded_components() returning
recorded components
--------------------------+---------------------------
 Reporter:  sbrajesh      |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  low           |   Milestone:  2.0
Component:  Activity      |     Version:  2.0
 Severity:  minor         |  Resolution:  fixed
 Keywords:                |
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8249"]:
 {{{
 #!CommitTicketReference repository="" revision="8249"
 By default, BP_Activity_Activity::get_registered_components() should not
 return components with only last_activity items

 Since moving last_activity items to be stored in the activity database,
 the
 'members' component now has activity associated with it. However, these
 items
 are not "real" activity items, in the sense that you would want to query
 them
 when pulling up an activity stream. BP core has excluded these items from
 general activity queries elsewhere. But in
 BP_Activity_Activity::get_registered_components(),
 we continued to return the members component, even when the only activity
 items associated with it were of the 'last_activity' variety. Though BP
 does
 not natively use this method anymore, it did break some plugins that were
 expecting a more sanitized list of components.

 Fixes #5519
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5519#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list