[buddypress-trac] [BuddyPress Trac] #5505: New activity check

[buddypress-trac]

#5505: New activity check
--------------------------+-----------------------
 Reporter:  SGr33n        |       Owner:  imath
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  2.0
Component:  Activity      |     Version:  2.0
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+-----------------------

Comment (by boonebgorges):

 So, I'm running out of time to finish up the patch I'm writing, so I'm
 going to post what I have with some thoughts. imath, since you wrote the
 JS, maybe you can finish the work (or tell me if you disagree with what
 I've started)

 - I agree that this has nothing to do with the mention in bbPress.
 - This only happens when the date_recorded value of an existing activity
 item is modified. I actually couldn't reproduce this with bbPress in the
 interface. Like imath, the only way I could do it was to manually force
 the discrepancy in the database (I did it with a direct SQL query, but the
 same idea)
 - Still, I think this needs to be fixed, because it's a fairly serious
 interface issue if there is a plugin that bumps old behavior in this way
 - I've opted to add a 'since' parameter alongside 'offset'. See
 5505.patch.
 - IMO, it's most logical for 'since' to accept a `Y-m-d H:i:s` value (see
 5505.patch). But it's safest from a JS point of view to pass an integer
 value back and forth. I started to work on this in the patch but ran out
 of time.
 - If we go with this, we're going to need another CSS class to activity
 items - something like `date-recorded-{$date_recorded}` (where
 $date_recorded will be a unix timestamp)

 imath, do you agree with this take on things? Is there any chance that you
 can finish what I've started in 5505.patch? If not, I can try to get to it
 tomorrow. Many thanks.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5505#comment:15>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac