[buddypress-trac] [BuddyPress Trac] #5399: Review metadata functions for irregularities

[buddypress-trac]

#5399: Review metadata functions for irregularities
--------------------------+---------------------------
 Reporter:  boonebgorges  |       Owner:  boonebgorges
     Type:  enhancement   |      Status:  closed
 Priority:  normal        |   Milestone:  2.0
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:  fixed
 Keywords:  2nd-opinion   |
--------------------------+---------------------------

Comment (by boonebgorges):

 In [changeset:"8237"]:
 {{{
 #!CommitTicketReference repository="" revision="8237"
 Don't do a strict type check when deciding on
 bp_activity_add_user_favorite() return value

 Since r8132, bp_activity_update_meta() has returned an integer value when
 falling through to add_metadata(). Thus, we should have a more generous
 test
 for whether the update has been successful. See #5399

 Fixes #5515
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5399#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac