[buddypress-trac] [BuddyPress Trac] #5509: invites-loop template re-factoring
buddypress-trac
noreply at wordpress.org
Wed Apr 2 20:42:27 UTC 2014
#5509: invites-loop template re-factoring
-------------------------+------------------
Reporter: hnla | Owner:
Type: enhancement | Status: new
Priority: low | Milestone: 2.1
Component: Theme | Version:
Severity: minor | Resolution:
Keywords: has-patch |
-------------------------+------------------
Comment (by hnla):
However headings they are and headings they ought to be sadly what you're
describing are theme issues with styles if there are issues with floated
elements then somewhere there need to be rules to clear elements of
sibling floats and this patch didn't purposfully take into account styling
which is a seperate mater. Markup should always be used in a semantic
manner it's then a matter for visual styling to decide how it wants to
render that to screen. Best way of understanding this and a practise
important to follow is to always disable styles to see what the DOM is
creating by way of structured markup flow.
I take the point though on what is being seen but sadly to circumvent
those issues probably means taking correct elements and changing to
something like a paragraph tag but that isn't a correct use they are not
paragraphs - or we visually style those new elements to render them
smaller. One issue that always will arise with themes though is that of
describing headings as it's too easy for heading to be inserted out of
sequence upsetting a natural flow.
I guess we can and ought to address a few simple styles if we go with this
re-factoring which I can attend to later.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5509#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list