[buddypress-trac] [BuddyPress Trac] #4785: Decouple "visibility" and "access" properties

[buddypress-trac]

#4785: Decouple "visibility" and "access" properties
----------------------------------------+------------------
 Reporter:  smninja                     |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  2.1
Component:  Groups                      |     Version:  1.7
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch needs-unit-tests


Comment:

 Thanks, dcavins. This looks promising. I'll have more time to spend with
 it after the 2.0 release. But in the meantime, I'll make the following
 observations:

 - The existing `visibility` and `enable_nav_item` properties probably date
 back to 1.1, when `BP_Group_Extension` was originally introduced. It's
 likely that their behavior is inconsistent. I'm totally on board with
 taking this opportunity to deprecate these properties in favor of
 centralized properties that make more sense.
 - But, it's going to be much easier to do this if we have unit test
 coverage for the current functionality. I think that the process of
 writing these tests will give us a clearer grasp of what the properties
 are *meant* to do and what they *actually* do, which will in turn help us
 decide how to consolidate them moving forward. If you can start to look at
 automated tests for the existing functionality, it'd get us a lot closer
 to making some of the proposed changes.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4785#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac