[buddypress-trac] [BuddyPress Trac] #2768: Use WP comments' threaded comment depth settings

[buddypress-trac]

#2768: Use WP comments' threaded comment depth settings
------------------------------+---------------------------
 Reporter:  DJPaul            |       Owner:  boonebgorges
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  2.0
Component:  Activity          |     Version:
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------------
Changes (by boonebgorges):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8226"]:
 {{{
 #!CommitTicketReference repository="" revision="8226"
 Better checks for existence of parent item when recursing to calculate
 activity comment depth

 The changes introduced in r8201 involve calculating tree depth for each
 queried
 activity comment in a loop. The technique used involves traversing up a
 tree by
 fetching the parent item until the root level is reached. However, the
 original
 technique did not account for the fact that in certain cases - namely,
 when
 display_comments=threaded - it may not be the case that all of the comment
 ancestors are available in the current query. This failed logic resulted
 in
 infinite regression in these sorts of cases.

 The correction involves performing a separate query for the direct
 activity
 parent when it is not found in the queried items.

 Props r-a-y

 Fixes #2768
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/2768#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac