[buddypress-trac] [BuddyPress] #5144: Don't set 'Create a Group' button as part of the title
buddypress-trac
noreply at wordpress.org
Fri Sep 13 21:22:40 UTC 2013
#5144: Don't set 'Create a Group' button as part of the title
--------------------------+------------------------------
Reporter: rogercoathup | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Theme | Version: 1.7
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------------------
Comment (by boonebgorges):
hnla - In the new template pack, I assume that the create buttons will be
created in a more sane way. The question is what to do about bp-legacy.
It's annoying that the "default condition" is to "inject into a heading
tag", but this is the way it currently works (and the way the templates
have worked since bp-default), so changing it at this point has the
potential to break the layouts of many sites that have embraced (or worked
around) the current setup. Changing the default behavior will mean
changing the markup on many existing sites, in a significant way. We
should try not to do this.
r-a-y's patch seems sensible to me - it allows savvy developers and theme
designers to opt out of our bad habit, but keeps the default the same for
the lifecycle of bp-legacy.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5144#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list