[buddypress-trac] [BuddyPress] #2242: make Group sticky
buddypress-trac
noreply at wordpress.org
Mon Sep 9 13:39:04 UTC 2013
#2242: make Group sticky
-------------------------------------------------+-------------------------
Reporter: erich73 | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future
Component: Groups | Release
Severity: normal | Version:
Keywords: has-patch needs-testing 2nd-opinion | Resolution:
-------------------------------------------------+-------------------------
Comment (by boonebgorges):
Thanks for the thoughful response, imath.
> what can be useful for a plugin is to easily have the arguments of
BP_Groups_Group::get()
Agreed. This would be useful for many reasons. I'm going to add it
immediately.
> convenient to merge this data before by adding a filter at line 516 of
bp-groups-classes.php
I'm wary of adding this kind of filter without first thinking about an
overall filtering strategy for all components with the rest of the team.
Since you can modify `$groups_template` directly, please go ahead and use
this technique for now.
> to include a specific style to a sticky group, i guess it needs a
specific template tag reason why the patch has included one
(bp_groups_group_class())
Could you please submit a patch with just this feature? It shouldn't be a
problem to add it.
Once these changes are in place, I'm leaning toward closing this ticket as
wontfix for now. I encourage you to build the feature as a plugin, and put
it out there to see if people use it and love it. I agree that the most
elegant place to do stickies is in core, but I don't want to take on the
extra baggage if we don't have good reason to believe that many people
will use it. If it turns out that your plugin is wildly popular, we can
reopen this ticket and reconsider. Does that sound reasonable?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/2242#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list