[buddypress-trac] [BuddyPress] #4984: Admin authority not being respected for xprofile field visibility

[buddypress-trac]

#4984: Admin authority not being respected for xprofile field visibility
--------------------------+---------------------------
 Reporter:  ubernaut      |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  high          |   Milestone:  1.8.2
Component:  XProfile      |     Version:  1.7
 Severity:  normal        |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7363"]:
 {{{
 #!CommitTicketReference repository="" revision="7363"
 Fix hidden xprofile fields for admins

 XProfile field visibility was not being calculated correctly for admins,
 due to incorrect logic in bp_xprofile_get_hidden_fields_for_user(). This
 changeset clears up the logic, by moving the bp_moderate check earlier
 in the flow.

 To make the changes easier to implement and to test, this changeset also
 breaks the calculation of visibility levels for a user-user pair into
 a separate function, bp_xprofile_get_hidden_field_types_for_user().

 Also introduces unit tests for the latter function.

 Fixes #4984

 Props imath
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4984#comment:22>
BuddyPress <http://buddypress.org/>
BuddyPress