[buddypress-trac] [BuddyPress] #5212: Enable upgrade route for BP-Default for future BP releases

[buddypress-trac]

#5212: Enable upgrade route for BP-Default for future BP releases
--------------------------+------------------
 Reporter:  DJPaul        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.0
Component:  Theme         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by johnjamesjacoby):

 Paul's patch looks okay to me at a cursory glance.

 I agree with Boone that we need to be very clear about breaking changes
 BuddyPress 2.0 is going to cause outdated installations, both in this
 regard and also with my wanting to remove old bbPress and/or `bp-forums`
 completely.

 Paul - I don't think your code will do very much. How often is a `*.php`
 file included inside of WordPress in such a way to cause the `bp_loaded`
 action to fire? If template files, scripts, or images are loaded directly,
 this code will never hook in to do anything there either.

 Instead of Paul's patch, can we move `bp-default` into `wp-content/themes
 /bp-default`, maybe on update, like the old Template Pack used to do? I'm
 thinking:

 * Check if the parent/child themes on the root site are using `bp-default`
 * If so, backup the theme options, and try copy the theme.
 * If the theme is copied successfully, update the appropriate theme
 option(s) and try to load the site.
 * If the site responds with a 200, delete `bp-default` from the BuddyPress
 directory, delete the backed-up options, assume success.
 * If anything fails, revert back to the original configuration and alert
 the site admin they need to move the theme folder manually.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5212#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress