[buddypress-trac] [BuddyPress] #5172: View conversation link to a non existent page

[buddypress-trac]

#5172: View conversation link to a non existent page
------------------------------+---------------------
 Reporter:  sgr33n            |       Owner:  r-a-y
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  1.9
Component:  Theme             |     Version:  1.7
 Severity:  major             |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by r-a-y):

 * owner:   => r-a-y
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7482"]:
 {{{
 #!CommitTicketReference repository="" revision="7482"
 Remove activity comment count check in activity entry template.

 Due to changes in r6410 to expand how activity comments are fetched, a
 comment count now existed for nested activity comments.

 Because the comment count now exists for nested activity comments, this
 had
 the unintended consequence of showing activity comments on singular
 activity comment entries.  Since the current javascript / AJAX code is
 unable to determine the parent activity ID correctly on a singular
 activity comment item, this would result in the "View Conversation" link
 being incorrect for replies that were made to these items.

 This commit resolves this issue by removing the activity comment count
 check, which will not output the activity comment form for singular
 activity comment entries.

 Fixes #5172.
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5172#comment:17>
BuddyPress <http://buddypress.org/>
BuddyPress