[buddypress-trac] [BuddyPress] #5204: Add class 'page' to bp_get_the _body_class() if theme compat active

buddypress-trac noreply at wordpress.org
Tue Oct 15 15:40:13 UTC 2013


#5204: Add class 'page' to bp_get_the _body_class() if theme compat active
-------------------------+-----------------------------
 Reporter:  hnla         |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  Core         |    Version:
 Severity:  normal       |   Keywords:  has-patch
-------------------------+-----------------------------
 Patch adds a class of 'page' to the body tag if theme compat returns true.

 Reason?:

 Ran across a forum post theme issue with BP rendering it's screens in a
 tiny narrow 300px wide element, styled on article.post, theme then set a
 desired size for it's layout based on '.page article.post' or '.single-
 post article.post' whereas this is a backwards bit of coding it did
 suggest the possibility of this as a re-occuring issue with themes; it's
 not the first time I have run across layouts relying on specific styling
 based on a parent class of .page or  .single-post. In the case of BP we
 essentially say that a theme compat template is in essence a WP page yet
 we do not pass through any class to suggest that to third party themes '
 buddypress' is useful but only if you know it exists.

 I propose the patch as a means of perhaps preventing a few themes from
 failing to present BP screens simply due to their styling based on
 presumed classes. I think, but am not 100% certain, that this should have
 no unintended consequences?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5204>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list