[buddypress-trac] [BuddyPress] #5185: BP Signup - spaces in username issue

[buddypress-trac]

#5185: BP Signup - spaces in username issue
-------------------------------------+------------------
 Reporter:  hnla                     |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  1.9
Component:  Core                     |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by hnla):

 @Boone Tested the patch manually and it seems fine, returns error on space
 used to allow the user to decide and more importantly know what their
 username is. We could expand the error text to add ? "Please replace
 spaces with hyphen or no space" but it's gilding the lilly and users can
 no doubt work out what to do.

 @henrywright it's not so much about disallowing characters (BP never did
 allow spaces) as the terrible UX of silent hyphen being added if spaces
 encountered without the user being aware.

 Where possible BP needs to be in tandem with what WP does / allows after
 all BP is subordinate to many WP functions & behaviours, gets confusing
 when/if BP diverges from the norm.

 It's why in #4939 I was trying to establish and highlight what characters
 were allowed matched to what WP allowed, got that slightly wrong though :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5185#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress